Re: [PATCH] tty: not call tty close in fallback
From: Jiri Slaby <hidden>
Date: 2019-01-14 07:20:20
Also in:
lkml
Possibly related (same subject, not in this thread)
- 2019-02-19 · Re: [PATCH] tty: not call tty close in fallback · Greg KH <gregkh@linuxfoundation.org>
- 2019-01-14 · Re: [PATCH] tty: not call tty close in fallback · Jiri Slaby <hidden>
- 2019-01-14 · [PATCH] tty: not call tty close in fallback · <hidden>
On 14. 01. 19, 7:56, yes@hpe.com wrote:
From: Li RongQing <redacted> when fail to open tty, tty is not in open status and not need to call close
But tty drivers are special and expect close even on failed open, right? See tty_open.
quoted hunk
Signed-off-by: Li RongQing <redacted> --- drivers/tty/serdev/serdev-ttyport.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)diff --git a/drivers/tty/serdev/serdev-ttyport.c b/drivers/tty/serdev/serdev-ttyport.c index fa1672993b4c..bcc1e27d00de 100644 --- a/drivers/tty/serdev/serdev-ttyport.c +++ b/drivers/tty/serdev/serdev-ttyport.c@@ -121,7 +121,7 @@ static int ttyport_open(struct serdev_controller *ctrl) ret = tty->ops->open(serport->tty, NULL); if (ret) - goto err_close; + goto err_unlock; tty_unlock(serport->tty);@@ -142,8 +142,6 @@ static int ttyport_open(struct serdev_controller *ctrl) return 0; -err_close: - tty->ops->close(tty, NULL); err_unlock: tty_unlock(tty); tty_release_struct(tty, serport->tty_idx);
thanks, -- js suse labs