Re: [PATCH v2 2/2] kgdboc: Change printk to the right fashion

On Tue, 2018-08-14 at 14:35 +0100, Daniel Thompson wrote:

On Tue, Aug 14, 2018 at 08:46:01PM +0800, zhe.he@windriver.com wrote:

quoted

From: He Zhe <redacted>

pr_* is preferred according to scripts/checkpatch.pl.

[]

quoted

diff --git a/drivers/tty/serial/kgdboc.c b/drivers/tty/serial/kgdboc.c

[]

quoted

@@ -136,7 +136,7 @@ static int kgdboc_option_setup(char *opt)
 	}
 
 	if (strlen(opt) >= MAX_CONFIG_LEN) {
-		printk(KERN_ERR "kgdboc: config string too long\n");
+		pr_err("kgdboc: config string too long\n");

Looks like you should remove the tags from pr_err and use pr_fmt(fmt) to
put tags on the messages:

#define pr_fmt(fmt) "kgdboc: " fmt

True and it's probably better to use:

#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt