Re: [PATCH v2 15/24] net: qualcomm: MODULE_DEVICE_TABLE(serdev)
From: Marcel Holtmann <marcel@holtmann.org>
Date: 2018-06-11 13:01:08
Also in:
lkml, netdev
Hi Ricardo,
quoted hunk ↗ jump to hunk
Export serdev table to the module header, allowing module autoload via udev/modprobe. Cc: Lino Sanfilippo <LinoSanfilippo@gmx.de> Cc: David S. Miller <davem@davemloft.net> Cc: Stefan Wahren <redacted> Cc: Rob Herring <robh@kernel.org> Cc: Johan Hovold <johan@kernel.org> Cc: netdev@vger.kernel.org Signed-off-by: Ricardo Ribalda Delgado <redacted> --- drivers/net/ethernet/qualcomm/qca_uart.c | 7 +++++++ 1 file changed, 7 insertions(+)diff --git a/drivers/net/ethernet/qualcomm/qca_uart.c b/drivers/net/ethernet/qualcomm/qca_uart.c index db6068cd7a1f..6d2ac6cae63f 100644 --- a/drivers/net/ethernet/qualcomm/qca_uart.c +++ b/drivers/net/ethernet/qualcomm/qca_uart.c@@ -405,6 +405,12 @@ static void qca_uart_remove(struct serdev_device *serdev)free_netdev(qca->net_dev); } +static struct serdev_device_id qca_uart_serdev_id[] = { + { QCAUART_DRV_NAME, }, + {} +}; +MODULE_DEVICE_TABLE(serdev, qca_uart_serdev_id); + static struct serdev_device_driver qca_uart_driver = { .probe = qca_uart_probe, .remove = qca_uart_remove,@@ -412,6 +418,7 @@ static struct serdev_device_driver qca_uart_driver = {.name = QCAUART_DRV_NAME, .of_match_table = of_match_ptr(qca_uart_of_match), }, + .id_table = qca_uart_serdev_id, };
the commit message is misleading me. If I build something with ACPI or DT support, then modinfo will show all modalias information for ACPI and DT compatible strings. What else does udev/modprobe actually need? Is something broken with the modalias export? Regards Marcel