Thread (50 messages) 50 messages, 16 authors, 2018-04-17

Re: [PATCH v2 10/21] lightnvm: Remove depends on HAS_DMA in case of platform dependency

From: Geert Uytterhoeven <hidden>
Date: 2018-03-20 10:09:06
Also in: alsa-devel, linux-crypto, linux-fpga, linux-i2c, linux-ide, linux-iio, linux-iommu, linux-mmc, linux-remoteproc, linux-scsi, linux-spi, lkml, netdev

Hi Madalin-cristian,

On Mon, Mar 19, 2018 at 6:27 AM, Madalin-cristian Bucur
[off-list ref] wrote:
quoted
-----Original Message-----
From: netdev-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org [mailto:netdev-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org]
On Behalf Of Geert Uytterhoeven
Remove dependencies on HAS_DMA where a Kconfig symbol depends on
another
symbol that implies HAS_DMA, and, optionally, on "|| COMPILE_TEST".
In most cases this other symbol is an architecture or platform specific
symbol, or PCI.

Generic symbols and drivers without platform dependencies keep their
dependencies on HAS_DMA, to prevent compiling subsystems or drivers that
cannot work anyway.

This simplifies the dependencies, and allows to improve compile-testing.

Notes:
  - FSL_FMAN keeps its dependency on HAS_DMA, as it calls set_dma_ops(),
    which does not exist if HAS_DMA=n (Do we need a dummy? The use of
    set_dma_ops() in this driver is questionable),
Hi,

The set_dma_ops() is no longer required in the fsl/fman, I'll send a patch to remove it.
Thank you, looking forward to it!
quoted
  - SND_SOC_LPASS_IPQ806X and SND_SOC_LPASS_PLATFORM loose their
    dependency on HAS_DMA, as they are selected from
    SND_SOC_APQ8016_SBC.

Signed-off-by: Geert Uytterhoeven <redacted>
Reviewed-by: Mark Brown <redacted>
Acked-by: Robin Murphy <redacted>
Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help