Re: [PATCH v3 05/33] nds32: Exception handling
From: Al Viro <viro@ZenIV.linux.org.uk>
Date: 2017-12-08 15:05:17
Also in:
linux-arch, linux-devicetree, lkml, netdev
On Fri, Dec 08, 2017 at 05:11:48PM +0800, Greentime Hu wrote:
quoted hunk ↗ jump to hunk
diff --git a/arch/nds32/kernel/traps.c b/arch/nds32/kernel/traps.c new file mode 100644 index 0000000..30a275d --- /dev/null +++ b/arch/nds32/kernel/traps.c@@ -0,0 +1,441 @@ +/* + * Copyright (C) 2005-2017 Andes Technology Corporation + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 as + * published by the Free Software Foundation. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program. If not, see <http://www.gnu.org/licenses/>. + */ + +#include <linux/module.h> +#include <linux/personality.h> +#include <linux/kallsyms.h> +#include <linux/hardirq.h> +#include <linux/kdebug.h> +#include <linux/sched/task_stack.h> + +#include <asm/proc-fns.h> +#include <asm/uaccess.h>
The only include of asm/uaccess.h should be in linux/uaccess.h; everything else should include linux/uaccess.h. The same goes for other patches in the series.