Thread (26 messages) 26 messages, 6 authors, 2017-08-16

Re: [RFC v2 3/6] serdev: add multiplexer support

From: Ulrich Hecht <hidden>
Date: 2017-08-16 13:23:37
Also in: linux-i2c, linux-renesas-soc

On Wed, Jul 19, 2017 at 1:06 AM, Rob Herring [off-list ref] wrote:
quoted
 static inline struct serdev_controller *to_serdev_controller(struct device *d)
@@ -172,7 +180,7 @@ static inline void serdev_controller_write_wakeup(struct serdev_controller *ctrl
 {
        struct serdev_device *serdev = ctrl->serdev;

-       if (!serdev || !serdev->ops->write_wakeup)
+       if (!serdev || !serdev->ops || !serdev->ops->write_wakeup)
When is ops ever NULL? Should be a separate change AFIACT.
I dumped it; IIRC that happened once during development due to a bug elsewhere.

CU
Uli
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help