Thread (16 messages) 16 messages, 4 authors, 2017-07-27

Re: [PATCH 0/2] Avoid crashes by early (boot) consoles using init memory

From: Petr Mladek <pmladek@suse.com>
Date: 2017-07-14 14:37:57
Also in: lkml

On Fri 2017-07-14 14:57:45, Fabio M. Di Nitto wrote:
Hi Petr,

On 7/14/2017 2:51 PM, Petr Mladek wrote:
quoted
Some early consoles have code and data in the init section. It makes some
sense but this might cause problems when they are not replaced by
the real console in time. The two patches fix the safequard and
help to avoid the problems.

I though about removing keep_bootcon option completely. But it is useful
at least for now.
Let´s just keep in mind that keep_bootcon was introduced only to debug
issues (read crashes or hangs) that could happen between disabling
bootconsole and enabling the real console. It shouldn´t be used for
anything else really.
This was my initial replay as well. But then I realized that
it was a bad idea to use a freed code and data to debug any other
issue. It would just create crazy issues on its own.

I tried to google 'keep_bootcon'. It found several links to strange
crashes related to this option. Maybe I was not patient enough but
I did not find any page where this option was suggested and helped.

I still think that the option makes some sense but only when
it does not cause more breakages on its own.
If the new code can replace keep_bootcon, by all mean, go for it :-)
keep_bootcon stays usable for most early consoles. We print a warning
when an unusable console is disabled too early. Also there is a
comment how to fix it.

Best Regards,
Petr
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help