Thread (2 messages) 2 messages, 1 author, 2017-05-20

Re: [PATCH] serial: of_serial: remove NULL pointer check for clk_disable_unprepare

From: Masahiro Yamada <hidden>
Date: 2017-05-20 19:05:12
Also in: lkml

2017-05-21 2:44 GMT+09:00 Masahiro Yamada [off-list ref]:
After long term efforts of fixing non-common clock implementations,
clk_disable() is a no-op for a NULL pointer input, and this is now
tree-wide consistent.

All clock consumers can safely call clk_disable(_unprepare) without
NULL pointer check.

Signed-off-by: Masahiro Yamada <redacted>

Sorry, I retract this patch.

Krzysztof pointed out
cleanups only for clk_disable_unprepare() will lose the code symmetry.

NULL pointer checks for clk_prepare_enable() should be
removed to keep the code symmetrical.

This is possible for common-clock framework because
clk_prepare_enable() is also a no-op for a NULL clk input.
But it is not necessarily true for non-common clock implementations.


-- 
Best Regards
Masahiro Yamada
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help