Thread (14 messages) 14 messages, 2 authors, 2017-02-08

Re: [PATCH 7/7] serial: exar: Enable MSI support

From: Andy Shevchenko <hidden>
Date: 2017-02-07 23:26:05
Also in: lkml

On Tue, Feb 7, 2017 at 6:10 PM, Jan Kiszka [off-list ref] wrote:
Use pci_alloc_irq_vectors to enable MSI when available. At least the
XR17V352 supports this.
FWIW:
Reviewed-by: Andy Shevchenko <redacted>
quoted hunk ↗ jump to hunk
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
 drivers/tty/serial/8250/8250_exar.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/tty/serial/8250/8250_exar.c b/drivers/tty/serial/8250/8250_exar.c
index 13cc1da..236de60 100644
--- a/drivers/tty/serial/8250/8250_exar.c
+++ b/drivers/tty/serial/8250/8250_exar.c
@@ -284,10 +284,16 @@ exar_pci_probe(struct pci_dev *pcidev, const struct pci_device_id *ent)

        priv->board = board;

+       pci_set_master(pcidev);
+
+       rc = pci_alloc_irq_vectors(pcidev, 1, 1, PCI_IRQ_ALL_TYPES);
+       if (rc < 0)
+               return rc;
+
        memset(&uart, 0, sizeof(uart));
        uart.port.flags = UPF_SKIP_TEST | UPF_BOOT_AUTOCONF | UPF_SHARE_IRQ
                          | UPF_EXAR_EFR;
-       uart.port.irq = pcidev->irq;
+       uart.port.irq = pci_irq_vector(pcidev, 0);
        uart.port.dev = &pcidev->dev;

        for (i = 0; i < nr_ports && i < maxnr; i++) {
--
2.1.4


-- 
With Best Regards,
Andy Shevchenko
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help