Thread (2 messages) 2 messages, 2 authors, 2017-02-07

Re: [PATCH] serial: sh-sci: Temporarily Revert "implement FIFO threshold register setting"

From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: 2017-02-07 13:06:23
Also in: lkml

Hi Arnd,

On Tue, Feb 7, 2017 at 2:00 PM, Arnd Bergmann [off-list ref] wrote:
Patch the first three patches out of seven were applied, up to commit
a380ed461f66 ("serial: sh-sci: implement FIFO threshold register setting"),
which introduces a new helper function. This is not called until the next
following patch, so we now get a build warning:

drivers/tty/serial/sh-sci.c:977:12: error: 'scif_set_rtrg' defined but not used [-Werror=unused-function]

The patch is good, but I think we should either apply the following patches
as well, or revert this one to get a clean build.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
This is mainly a notification that I've applied the revert to my randconfig
test tree, if you plan to merge the following patches for 4.11, we won't
need this one.
The follow-up commits were added to tty/tty-next earlier today.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help