Thread (40 messages) 40 messages, 8 authors, 2017-01-14

Re: [PATCH 8/9] serdev: add a tty port controller driver

From: Rob Herring <robh@kernel.org>
Date: 2017-01-13 15:28:36
Also in: linux-bluetooth, lkml

On Fri, Jan 13, 2017 at 9:04 AM, Andy Shevchenko
[off-list ref] wrote:
On Thu, 2017-01-12 at 10:01 -0600, Rob Herring wrote:
quoted
On Sat, Jan 7, 2017 at 8:11 AM, Andy Shevchenko
[off-list ref] wrote:
quoted
On Fri, 2017-01-06 at 10:26 -0600, Rob Herring wrote:
quoted
Add a serdev controller driver for tty ports.

The controller is registered with serdev when tty ports are
registered
with the TTY core. As the TTY core is built-in only, this has the
side
effect of making serdev built-in as well.


+if SERIAL_DEV_BUS
+
+config SERIAL_DEV_CTRL_TTYPORT
+     bool "Serial device TTY port controller"
+     depends on TTY
+     depends on SERIAL_DEV_BUS=y
Do you need one?
Yes, otherwise the bus can be built as a module and this driver can
still be enabled breaking the build. I could drop supporting building
the bus as a module because as long as this is the only controller
driver, it all has to be built-in.
Would

if SERIAL_DEV_BUS=y

work for you?
Yes, until we add a driver that doesn't have to be built-in. What
about "depends on SERIAL_DEV_BUS != m"? That would be a bit more clear
what the reason is.

Rob
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help