Re: [PATCH] ACPI / platform: Add support for build-in properties
From: "Rafael J. Wysocki" <rafael@kernel.org>
Date: 2016-11-09 23:40:52
Also in:
linux-acpi, linux-bluetooth
From: "Rafael J. Wysocki" <rafael@kernel.org>
Date: 2016-11-09 23:40:52
Also in:
linux-acpi, linux-bluetooth
On Sun, Nov 6, 2016 at 5:09 PM, Jérôme de Bretagne [off-list ref] wrote:
Le jeudi 03 novembre 2016 à 16:21 +0200, Heikki Krogerus a écrit :quoted
We have a couple of drivers, acpi_apd.c and acpi_lpss.c, that need to pass extra build-in properties to the devices they create. Previously the drivers added those properties to the struct device which is member of the struct acpi_device, but that does not work. Those properties need to be assigned to the struct device of the platform device instead in order for them to become available to the drivers. To fix this, this patch changes acpi_create_platform_device function to take struct property_entry pointer as parameter. Fixes: 20a875e2e86e ("serial: 8250_dw: Add quirk for APM X-Gene SoC") Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> --- Hi, Found the problem, and this is my proposal for a fix. Jérôme, please test it when you have time.Hi Heikki, I can confirm that this patch fixes the issue I've reported on the Lenovo ThinkPad 8 tablet. You were fast to find the root cause, impressive, really appreciated. Feel free to add: Tested-by: Jérôme de Bretagne <redacted> Let's hope it can still make it during the remaining 4.9 rc timing.
It's in my linux-next branch now (it should hit linux-next on Friday) and I'm going to push it for -rc5 if it doesn't lead to problems. Thanks, Rafael