Thread (5 messages) 5 messages, 2 authors, 2017-01-17

[PATCH] Revert "tty: serial: 8250: add CON_CONSDEV to flags"

flat view
STALE3557d

From: Huacai Chen <hidden>
Date: 2016-11-14 02:53:38
Also in: stable
Subsystem: 8250/16?50 (and clone uarts) serial driver, the rest, tty layer and serial drivers · Maintainers: Greg Kroah-Hartman, Linus Torvalds, Jiri Slaby

This reverts commit d03516df837587368fc6e75591f6329c072b9eb5. From
Documentation/serial-console.txt we can know that serial port becomes
the system console only when it appears in the kernel parameters as the
last console device. But commit d03516df837587 adds a CON_CONSDEV flag
to univ8250_console and breaks this convention. After that either we
use "console=tty console=ttyS0" or "console=ttyS0 console=tty", serial
port will always be the system console.

Cc: stable@vger.kernel.org
Signed-off-by: Ce Sun <redacted>
Signed-off-by: Huacai Chen <redacted>
---
 drivers/tty/serial/8250/8250_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/serial/8250/8250_core.c b/drivers/tty/serial/8250/8250_core.c
index 240a361..e8819aa 100644
--- a/drivers/tty/serial/8250/8250_core.c
+++ b/drivers/tty/serial/8250/8250_core.c
@@ -675,7 +675,7 @@ static struct console univ8250_console = {
 	.device		= uart_console_device,
 	.setup		= univ8250_console_setup,
 	.match		= univ8250_console_match,
-	.flags		= CON_PRINTBUFFER | CON_ANYTIME | CON_CONSDEV,
+	.flags		= CON_PRINTBUFFER | CON_ANYTIME,
 	.index		= -1,
 	.data		= &serial8250_reg,
 };
-- 
2.7.0
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help