Re: [PATCH] serial: sirf: Simplify a test
From: Christophe JAILLET <hidden>
Date: 2016-11-08 07:18:36
Also in:
kernel-janitors, linux-arm-kernel, lkml
From: Christophe JAILLET <hidden>
Date: 2016-11-08 07:18:36
Also in:
kernel-janitors, linux-arm-kernel, lkml
Le 07/11/2016 à 14:50, Arnd Bergmann a écrit :
On Tuesday, November 1, 2016 8:03:33 AM CET Christophe JAILLET wrote:quoted
'dmaengine_prep_dma_cyclic()' does not return an error pointer, so the test can be simplified to be more consistent. Signed-off-by: Christophe JAILLET <redacted>The change looks correct in principle. It would be good to automate looking for other instances of this bug. How did you find it? Do you have e.g. a coccinelle script or did you just stumble over the issue by accident?
Hi,
You can have an idea of the strategy used in this post:
https://lkml.org/lkml/2016/11/1/388
Julia is currently working on a more complete strategy in order to find
such issues.
In the meantime, if you want, I can send the coccinelle scripts used.
Best regards,
CJ