Hello,

On Tue, Sep 27, 2016 at 10:43:54PM +0900, 남영민 wrote:

quoted

This patch adds clock controls in s3c24xx_serial_resume_noirq() to set
S3C64XX_UINTM register.

Code looks correct but the commit message is bogus. It does not bring any
benefit over the code, not mentioning that it is quite cryptic (what does
the "clock controls" mean?).

Just describe here WHAT is the problem and WHY the fix is needed.

Best regards,
Krzysztof

Thank you for taking your time for the review.
I will improve the commit message applying your suggestions and resend this patch.

Best regards,
Youngmin Nam

quoted

Signed-off-by: Youngmin Nam <redacted>
---
 drivers/tty/serial/samsung.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/tty/serial/samsung.c

b/drivers/tty/serial/samsung.c index ae2095a..97f7b3b 100644

--- a/drivers/tty/serial/samsung.c
+++ b/drivers/tty/serial/samsung.c

@@ -1921,6 +1921,7 @@ static int s3c24xx_serial_resume(struct device

*dev)  static int s3c24xx_serial_resume_noirq(struct device *dev)  {
 	struct uart_port *port = s3c24xx_dev_to_port(dev);
+	struct s3c24xx_uart_port *ourport = to_ourport(port);

 	if (port) {
 		/* restore IRQ mask */

@@ -1930,7 +1931,9 @@ static int s3c24xx_serial_resume_noirq(struct

device *dev)

quoted

 				uintm &= ~S3C64XX_UINTM_TXD_MSK;
 			if (rx_enabled(port))
 				uintm &= ~S3C64XX_UINTM_RXD_MSK;
+			clk_prepare_enable(ourport->clk);
 			wr_regl(port, S3C64XX_UINTM, uintm);
+			clk_disable_unprepare(ourport->clk);
 		}
 	}

--
2.8.1


--
To unsubscribe from this list: send the line "unsubscribe
linux-samsung-soc" in the body of a message to
majordomo@vger.kernel.org More majordomo info at

http://vger.kernel.org/majordomo-info.html