Re: [PATCHv4 2/3] tty/serial: at91: fix hardware handshake with GPIOs
From: Richard Genoud <hidden>
Date: 2016-09-30 11:46:19
Also in:
linux-arm-kernel, lkml
From: Richard Genoud <hidden>
Date: 2016-09-30 11:46:19
Also in:
linux-arm-kernel, lkml
2016-09-30 13:16 GMT+02:00 Alexandre Belloni [off-list ref]:
On 30/09/2016 at 13:04:28 +0200, Richard Genoud wrote :quoted
Anyway, the problematics setups are all the setups with USMODE_HWHS enabled on platform without Fifos or PDC, i.e. all platforms but sama5d2 (Cyrille, correct me if I'm wrong).This is a wrong assumption, at91rm9200 to at91sam9g45 all have a pdc. Please, don't break those platforms. The only affected platforms are sam9x5, sama5d3 and sama5d4.
Have you tested them ? And why are you saying that rm9200 and g45 will be broken with this patch ? If they have a pdc, they will fall in the case: (atmel_use_pdc_rx(port) || atmel_use_fifo(port)) and thus use: mode |= ATMEL_US_USMODE_HWHS; won't they ?