Thread (14 messages) 14 messages, 5 authors, 2016-09-02

Re: [PATCH 3/9] serial: altera: constify uart_ops structures

From: Tobias Klauser <tklauser@distanz.ch>
Date: 2016-09-02 08:47:07
Also in: kernel-janitors, lkml

On 2016-09-01 at 19:51:32 +0200, Julia Lawall [off-list ref] wrote:
Check for uart_ops structures that are only stored in the ops field of a
uart_port structure.  This field is declared const, so uart_ops structures
that have this property can be declared as const also.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@r disable optional_qualifier@
identifier i;
position p;
@@
static struct uart_ops i@p = { ... };

@ok@
identifier r.i;
struct uart_port e;
position p;
@@
e.ops = &i@p;

@bad@
position p != {r.p,ok.p};
identifier r.i;
struct uart_ops e;
@@
e@i@p

@depends on !bad disable optional_qualifier@
identifier r.i;
@@
static
+const
 struct uart_ops i = { ... };
// </smpl>

Signed-off-by: Julia Lawall <redacted>
Acked-by: Tobias Klauser <tklauser@distanz.ch>

Thanks a lot.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help