Thread (4 messages) 4 messages, 2 authors, 2016-08-08

Re: [PATCH 1/2] sc16is7xx: Do not handle irqs in endless loop

From: Dirk Eibach <hidden>
Date: 2016-08-08 14:02:18
Also in: lkml

2016-08-08 15:43 GMT+02:00 Greg KH [off-list ref]:
On Mon, Aug 08, 2016 at 03:32:15PM +0200, dirk.eibach@gdsys.cc wrote:
quoted
From: Dirk Eibach <redacted>

sc16is7xx_port_irq() is laid out as an endless loop. It will exit only
when there is no more interrupt left to service. This not common
practice.
In our case it lead to some strange hangup situation when there was an
unexpected XOFF-interrupt that could not be handled.
So let's service interrupts only once and report XOFF-interrupts that
should never happen since they are never enabled.

Signed-off-by: Dirk Eibach <redacted>

Conflicts:
      drivers/tty/serial/sc16is7xx.c
Why are these 2 lines in here?
Sorry, my bad. I have no idea how they slipped in. Will remove them in v2.

Cheers
Dirk
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help