Thread (8 messages) 8 messages, 5 authors, 2016-06-22

Re: [PATCH v2] tty: serial: msm: Don't reconfigure same baud rate

From: Nicolas Dechesne <hidden>
Date: 2016-06-21 10:10:17
Also in: linux-arm-msm, lkml

On Fri, Jun 17, 2016 at 1:02 PM, Nicolas Dechesne
[off-list ref] wrote:
[off-list ref] wrote:
quoted
msm_set_termios() is called whenever the tty is opened. Setting the baud
rate requires a full reset of the msm serial block, even when the rate
is unchanged. In the case when the same uart is used as console this
reset will discard any console output data still being clocked out of
the TX fifo.

By skipping the rate-change in the case where the baud rate is unchanged
since last request we can avoid the reset and the discarding of the
data.

Signed-off-by: Bjorn Andersson <redacted>

Tested-by: Nicolas Dechesne <redacted>

I no longer see this type of corruption on serial console

[    6.325118] ALSA device �[    6.333338] Freeing unused kernel
memory: 572K (ffffffc000c10000 - ffffffc000c9f000)
[   13.800269]  remoteproc2: remote processor a20400�[  OK  ] Started
Start the WCN core.
[ �         Starting Update UTMP about System Runlevel Changes...

oops. today i tried on APQ8064 boards , both IFC6410Plus and SD
600eval, and I can no longer 'type' into the serial console, I can get
debug messages though. Reverting this change 'fixes' the problem.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help