Thread (4 messages) 4 messages, 3 authors, 2016-06-10

Re: [RFC PATCH 05/15] tty: serial: samsung: fixup accessors for endian

From: Krzysztof Kozlowski <hidden>
Date: 2016-06-10 11:47:49
Also in: linux-arm-kernel, linux-samsung-soc, lkml

On 06/10/2016 12:13 PM, Ben Dooks wrote:
On 08/06/16 19:31, Matthew Leach wrote:
quoted
Fix the serial access code to deal with kernels built for big endian
operation.

Signed-off-by: Matthew Leach <redacted>
---
CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
CC: Jiri Slaby <redacted>
CC: linux-serial@vger.kernel.org
CC: linux-kernel@vger.kernel.org
---
 drivers/tty/serial/samsung.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/tty/serial/samsung.h b/drivers/tty/serial/samsung.h
index fc5deaa..8818bdd 100644
--- a/drivers/tty/serial/samsung.h
+++ b/drivers/tty/serial/samsung.h
@@ -118,9 +118,9 @@ struct s3c24xx_uart_port {
 	((unsigned long *)(unsigned long)((port)->membase + (reg)))
 
 #define rd_regb(port, reg) (__raw_readb(portaddr(port, reg)))
-#define rd_regl(port, reg) (__raw_readl(portaddr(port, reg)))
+#define rd_regl(port, reg) (readl_relaxed(portaddr(port, reg)))
For completeness we should have changed __raw_readb to readb_relaxed
quoted
 #define wr_regb(port, reg, val) __raw_writeb(val, portaddr(port, reg))
-#define wr_regl(port, reg, val) __raw_writel(val, portaddr(port, reg))
+#define wr_regl(port, reg, val) writel_relaxed(val, portaddr(port, reg))
Acked-by: Ben Dooks <redacted>

With the readb_relaced change:
Reviewed-by: Krzysztof Kozlowski <redacted>

Best regards,
Krzysztof
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help