Thread (4 messages) 4 messages, 2 authors, 2016-06-10

Re: [PATCH] serial_core: Change UART PM state to OFF on failure

From: Pramod Gurav <hidden>
Date: 2016-06-06 12:06:49
Also in: lkml

On 6 May 2016 at 15:16, Pramod Gurav [off-list ref] wrote:
quoted hunk ↗ jump to hunk
uart_change_pm is used to turn on the UART controller resources and
change UART's PM status. On failure to allocate pages the controller
be left in ON state. This will change the state to OFF on failure.

Signed-off-by: Pramod Gurav <redacted>
---
 drivers/tty/serial/serial_core.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_core.c
index 62fe368..58af2e9 100644
--- a/drivers/tty/serial/serial_core.c
+++ b/drivers/tty/serial/serial_core.c
@@ -156,9 +156,10 @@ static int uart_port_startup(struct tty_struct *tty, struct uart_state *state,
        if (!state->xmit.buf) {
                /* This is protected by the per port mutex */
                page = get_zeroed_page(GFP_KERNEL);
-               if (!page)
+               if (!page) {
+                       uart_change_pm(state, UART_PM_STATE_OFF);
                        return -ENOMEM;
-
+               }
                state->xmit.buf = (unsigned char *) page;
                uart_circ_clear(&state->xmit);
        }
Greg,
Any comments on this change?
--
1.8.2.1
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help