Thread (16 messages) 16 messages, 4 authors, 2016-03-22
STALE3742d

Re: [PATCH 2/2] serial: amba-pl011: complete support to ZTE uart

From: Jun Nie <hidden>
Date: 2016-03-22 01:16:13
Also in: linux-arm-kernel

2016-03-22 4:39 GMT+08:00 Timur Tabi [off-list ref]:
Jun Nie wrote:
quoted
@@ -2570,9 +2608,17 @@ static int pl011_uart_plat_probe(struct
platform_device *pdev)
        if (!uap)
                return -ENOMEM;

+       uap->clk = devm_clk_get(&pdev->dev, NULL);
+       if (IS_ERR(uap->clk))
+               return PTR_ERR(uap->clk);
+

I don't this is supposed to be part of your patch, and it breaks my ACPI
platform anyway.  Where did it come from?
Is it OK to move to device tree part, I mean if (pdev->dev.of_node)
clause? It is part of my patch, I am not aware ACPI requirement on
this.

Jun
--
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
Forum, a Linux Foundation collaborative project.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help