Thread (21 messages) 21 messages, 4 authors, 2016-02-12

Re: [PATCH v2 4/6] serial: 8250/uniphier: fix modular build

From: Masahiro Yamada <hidden>
Date: 2016-02-12 16:38:12
Also in: linux-arm-kernel, lkml

Hi Arnd,


2016-02-12 19:07 GMT+09:00 Arnd Bergmann [off-list ref]:
On Friday 12 February 2016 18:37:08 Masahiro Yamada wrote:
quoted
quoted
 };

-#ifdef CONFIG_SERIAL_8250_CONSOLE
+#if defined(CONFIG_SERIAL_8250_CONSOLE) && !defined(MODULE)
 static int __init uniphier_early_console_setup(struct earlycon_device *device,
                                               const char *options)
 {
--
2.7.0
I noticed commit 2eaa790989e03900298ad24f77f1086dbbc1aebd
revived this link error, but I am not happy with seeing
this patch again and again.


Can you check this patch?
https://patchwork.kernel.org/patch/8289231/

Yes, I think your patch is nicer than mine. Let's see what the others
think, then I can resend my remaining patches on top of yours.
As Peter pointed out, my patch would not work without CONFIG_OF.

I can not suggest any other alternative,
so I am OK with this patch.

Unfortunately, the "tty-linus" branch is getting dirty with
apply, revert, apply again.



-- 
Best Regards
Masahiro Yamada
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help