Thread (8 messages) 8 messages, 5 authors, 2016-02-22

Re: [PATCH v6] serial: rewrite pxa2xx-uart to use 8250_core

From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: 2016-02-07 06:22:09
Also in: lkml

Possibly related (same subject, not in this thread)

On Thu, Dec 24, 2015 at 06:15:14PM +0300, Sergei Ianovich wrote:
pxa2xx-uart was a separate uart platform driver. It was declaring
the same device names and numbers as 8250 driver. As a result,
it was impossible to use 8250 driver on PXA SoCs.

Upon closer examination pxa2xx-uart turned out to be a clone of
8250_core driver.

Workaround for Erratum #19 according to Marvel(R) PXA270M Processor
Specification Update (April 19, 2010) is dropped. 8250_core reads
from FIFO immediately after checking DR bit in LSR.

The patch leaves the original SERIAL_PXA driver around. The original
driver is just marked DEPRECATED in Kconfig and C source. When
the original driver is considered safe to remove, no changes
to SERIAL_8250 will be necessary.
But, you just broke existing configurations, right?  The serial port is
a different name now, are you willing to handle the angry users?

If so, great, get the platform maintainer to sign off on this please and
then resend it.

thanks,

greg k-h
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help