Re: [PATCH 1/3] printk: make preferred_console local static bool
From: Joe Perches <joe@perches.com>
Date: 2016-01-25 13:23:31
Also in:
linux-acpi, linux-arm-kernel, lkml
On Mon, 2016-01-25 at 18:51 +0600, Aleksey Makarov wrote:
On 25.01.2016 18:45, Joe Perches wrote:quoted
On Mon, 2016-01-25 at 17:45 +0600, Aleksey Makarov wrote:quoted
The variable preferred_console is used only inside register_console() and it's semantics is boolean. Make it clear.This loses the index of the preferred console. I'm not sure this is better.That index is not used anywhere. I believe the patch makes things clear.
Well, with this change the name and its use is a bit misleading. Maybe changing it to something like use_selected_console is better. -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html