Re: [PATCH v4 00/11] Earlycon cleanup
From: Rob Herring <robh+dt@kernel.org>
Date: 2016-01-12 23:53:21
Also in:
lkml
On Tue, Jan 12, 2016 at 1:41 PM, Peter Hurley [off-list ref] wrote:
Hi Greg, Grant & Rob, This patch series is a rebase of the v3 from April last year. This patch series builds on my earlier "Extensible console matching & direct earlycon" to add several useful features to earlycon: * Proper port i/o configuration from DT node with of_serial properties (such as reg-io-width, reg-shift and reg-offset, and endianness) * Proper console name & index initialization from earlycon name (for both command line and DT-defined earlycons) * Support for DT 'stdout-path' options pass-through to earlycon setup * Improved log messages for troubleshooting * Support for multiple OF earlycon declarations so different compatible strings can specify the same OF earlycon * Changes from v3 - Added 32-bit big-endian support - Removed the omap8250 earlycon (will follow later) Rob has expressed a desire to have the DT parts live in drivers/of/fdt.c The problem with this approach is two-fold. Firstly, the number of required parameters quickly becomes ugly (base address, io reg width, io reg offset, io reg stride, endianness, earlycon name). Secondly, drivers are already requiring access to alternate DT properties, like clocks, to initialize earlycons, and this requirement will continue.
I dislike ugliness more. So other than my one nit, for the series: Acked-by: Rob Herring <robh@kernel.org>