Thread (18 messages) 18 messages, 5 authors, 2016-01-20

Re: [PATCH -next] tty/serial: atmel: Include module.h to fix build failure

From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Date: 2016-01-11 11:34:39
Also in: lkml

On Mon, Jan 11, 2016 at 03:11:01AM -0800, Guenter Roeck wrote:
On Mon, Jan 11, 2016 at 02:05:36PM +0530, Sudip Mukherjee wrote:
quoted
On Sat, Jan 09, 2016 at 10:29:08AM -0800, Greg Kroah-Hartman wrote:
quoted
On Sat, Jan 09, 2016 at 10:15:35AM -0800, Guenter Roeck wrote:
quoted
If serial/atmel_serial.c is compiled with devicetree enabled, the
following build error is observed.

drivers/tty/serial/atmel_serial.c:192:1: warning:
	data definition has no type or storage class
drivers/tty/serial/atmel_serial.c:192:1: error:
	type defaults to 'int' in declaration of 'MODULE_DEVICE_TABLE'
drivers/tty/serial/atmel_serial.c:192:1: warning:
	parameter names (without types) in function declaration

MODULE_DEVICE_TABLE is used to specify devicetree compatibilities.

Fixes: c39dfebc7798 ("drivers/tty/serial: make serial/atmel_serial.c explicitly non-modular")
Cc: Paul Gortmaker <redacted>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
 drivers/tty/serial/atmel_serial.c | 1 +
 1 file changed, 1 insertion(+)
This hit my tree last night already with commit
041497eb721ddbdc1e690316976dd8ba7bc136a2, so all should be fine in the
next linux-next release.
Hi Guenter,
Just a thought. It has happended many times that we both have sent
patches to fix the same build fail. Maybe your patch got applied and
mine came late or maybe mine was applied and you came late. But I think
if we have a separate mailing list where people interested to fix and
monitor build failures will be members and we Cc that list whenever we
send patch for build fail and then in that case we will know that
someone else has already sent a patch for this failure and we can invest
the time in some other problem.
Hi Sudip,

I agree, it would make sense to have a build(/runtime?)-fixes-only mailing
list. Question though is how to limit noise on such a list
The list can be moderated for non-subscribers. We both can be admin and
can approve the mails if it is relevant to this list. Due to our
timezones atleast one of us will be always available to approve mails.
and, of course, > where and how to set it up. Any thoughts ?
since the list is kernel related, i think the best place should be
vger.kernel.org but I have no idea how or whom to approach to have a
list there. Maybe Greg can guide.
And if that is not possible then there are many alternatives.

regards
sudip
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help