-----Original Message-----
From: Borislav Petkov [mailto:bp@alien8.de]
Sent: Wednesday, January 06, 2016 6:46 PM
To: Wang, Annie
Cc: Andy Shevchenko; Vinod Koul; Mika Westerberg; Greg Kroah-Hartman; Rafael
J. Wysocki; linux-acpi@vger.kernel.org; linux-kernel@vger.kernel.org; linux-
serial@vger.kernel.org; dmaengine@vger.kernel.org; Huang, Ray; Wan, Vincent;
Xue, Ken; Robin Murphy; Graeme Gregory; Li, Tony; Yu, Xiangliang
Subject: Re: [PATCH 1/6] 8250/Kconfig: add config option
CONFIG_SERIAL_8250_AMD

On Wed, Jan 06, 2016 at 02:08:18AM +0000, Wang, Annie wrote:

quoted

How about I add select ARM_AMBA and SERIAL_8250 in arch/x86/Kconfig?

Yeah, select sounds good in that case, except in that particular case ...

quoted

diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig index

db3622f..0fe6657 100644

--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig

@@ -537,11 +537,15 @@ config X86_AMD_PLATFORM_DEVICE
        depends on ACPI
        select COMMON_CLK
        select PINCTRL
+       select SERIAL_8250
+       select ARM_AMBA

... that's a X86_AMD_PLATFORM_DEVICE which selects ARM thing? i.e.,
ARM_AMBA. Can that even work?

[ Rant on the side: And that ARM_AMBA thing has, of course, no effing
 help text. Dammit, people need to start explaining those cryptic
 abbreviations. Somewhere in the code I found "Advanced Microcontroller
 Bus Architecture". This is clearly suboptimal. ]

So why does the X86 platform device need to select the AMBA crap?

Russell, 

The AMBA bus is already leveraged  in AMD X86 arch hardware design for UART
controller and UART DMA. And may will be used in other arch as well, however,
it is rather confusing if we select ARM_AMBA in other arch, such as X86.

How about rename  CONFIG_ARM_AMBA to CONFIG_AMBA? So different arch
can select it without causing misunderstanding. 

Thank you very much.
Regards,
Hongcheng(Annie)