Thread (6 messages) 6 messages, 3 authors, 2015-10-08

Re: [PATCH] serial: atmel: fix compiler warning on address cast

From: Russell King - ARM Linux <hidden>
Date: 2015-10-08 09:38:06
Also in: linux-arm-kernel, lkml

On Thu, Oct 08, 2015 at 11:01:48AM +0200, Alexandre Belloni wrote:
On 05/10/2015 at 18:00:52 +0100, Andre Przywara wrote :
quoted
Turning on KVM and LPAE support on top of a multi_v7_defconfig will
produce a compiler warning in the Atmel serial driver:
drivers/tty/serial/atmel_serial.c: In function 'atmel_verify_port':
drivers/tty/serial/atmel_serial.c:2299:6: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
  if ((void *)port->mapbase != ser->iomem_base)
      ^

Fix that by using the cast on the right hand side instead, as similar
code already does in other drivers.

Signed-off-by: Andre Przywara <andre.przywara@arm.com>
Acked-by: Alexandre Belloni <redacted>
Hmm, this actually points at a problem, and the cast screems out about it.
Think about it, can you guess what it is?

-- 
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help