-----Original Message-----
From: Greg KH [mailto:gregkh@linuxfoundation.org]
Sent: 2015年7月23日 19:37
To: Wang Shenwei-B38339
Cc: linux-serial@vger.kernel.org; linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/1] Serial: imx: add dev_pm_ops to support suspend to
ram/disk

quoted

+	sport->saved_reg[4] = readl(sport->port.membase + UFCR);
+	sport->saved_reg[5] = readl(sport->port.membase + UESC);
+	sport->saved_reg[6] = readl(sport->port.membase + UTIM);
+	sport->saved_reg[7] = readl(sport->port.membase + UBIR);
+	sport->saved_reg[8] = readl(sport->port.membase + UBMR);
+	sport->saved_reg[9] = readl(sport->port.membase + IMX21_UTS);
+	clk_disable(sport->clk_ipg);
+
+	pr_debug("0x%p (%d)\r\n", sport->port.membase, sport->port.line);

You have a struct device, please use dev_dbg() instead.

Adopted in PATCH v2.

quoted

+
+	return 0;
+}
+
+	writel(sport->saved_reg[2], sport->port.membase + UCR3);
+	writel(sport->saved_reg[3], sport->port.membase + UCR4);
+	clk_disable(sport->clk_ipg);
+
+	pr_debug("0x%p (%d)\r\n", sport->port.membase, sport->port.line);

Same here, please use dev_dbg()

Adopted in PATCH v2.

Thanks,
Shenwei

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel