Re: [PATCH] Fix data loss in cdc-acm
From: Sven Brauch <hidden>
Date: 2015-07-22 22:53:22
Also in:
lkml
Attachments
- signature.asc [application/pgp-signature] 819 bytes
From: Sven Brauch <hidden>
Date: 2015-07-22 22:53:22
Also in:
lkml
Hi, On 23/07/15 00:12, Peter Hurley wrote:
The premature unthrottle actually leads to the data loss but the throttling with a mere 2K left is _way too late_.
Ok, yes, I think so too.
10ms is a _really_ long time for a cpu not to attend to a kworker. Which raises 2 questions: 1. What are the termios settings of the tty receiving input? Is it 'raw' mode or typical terminal mode (icanon, echo, etc.) or something else?
In my test code, I open the tty like
fd = open("/dev/ttyACM0", O_RDWR | O_NOCTTY | O_NONBLOCK);
I don't make any other changes to the default settings. To be honest,
I'm not sure in which mode it is operating then (I was assuming raw, but
I might be wrong?).
2. Are there RT threads that are hogging cpu time?
I can't see any, I think the only thing which occasionally goes to RT is pulseaudio (but during at least some of the tests I wasn't even playing audio, so that sounds very unplausible to me). I also cannot see a correlation between failure rate and CPU load. Best regards, Sven