Re: [PATCH 2/7] tty: core: Add tty_debug() for printk(KERN_DEBUG) messages
From: Joe Perches <joe@perches.com>
Date: 2015-07-13 04:30:42
Also in:
lkml
From: Joe Perches <joe@perches.com>
Date: 2015-07-13 04:30:42
Also in:
lkml
On Mon, 2015-07-13 at 00:25 -0400, Peter Hurley wrote:
On 07/12/2015 11:47 PM, Joe Perches wrote:quoted
On Sun, 2015-07-12 at 22:49 -0400, Peter Hurley wrote:quoted
Introduce tty_debug() macro to output uniform debug information for tty core debug messages (function name and tty name).[]quoted
diff --git a/drivers/tty/tty_io.c b/drivers/tty/tty_io.c[]quoted
@@ -768,7 +768,7 @@ static void do_tty_hangup(struct work_struct *work) void tty_hangup(struct tty_struct *tty) { #ifdef TTY_DEBUG_HANGUP - printk(KERN_DEBUG "%s hangup...\n", tty_name(tty)); + tty_debug(tty, "\n");Why drop the "hangup..." ?tty_debug() prints the function name; in this case, tty_hangup().
maybe that #ifdef/#endif block could/should be removed and the function tracer used to track this instead. cheers, Joe