Thread (41 messages) 41 messages, 15 authors, 2015-03-12
STALE4113d REVIEWED: 1 (0M)
Revisions (5)
  1. v1 [diff vs current]
  2. v1 [diff vs current]
  3. v1 current
  4. v1 [diff vs current]
  5. v1 [diff vs current]

Re: [PATCH 1/8] clk: add helper function clk_is_match()

From: Shawn Guo <hidden>
Date: 2015-02-26 00:37:58
Also in: alsa-devel, dri-devel, linux-arm-kernel, linux-pwm

On Wed, Feb 25, 2015 at 09:27:57AM -0800, Mike Turquette wrote:
Hi Shawn,

Thanks for the patch. I wrote a similar one last night but did not
finish fixing up the drivers (and thus did not post it). I prefer my
implementation below, and I'm happy to merge your driver fixes with it.
Sure, no problem.  My intention was to get rmk's HummingBoard back to
work ASAP :)
From: Michael Turquette <redacted>
Date: Wed, 25 Feb 2015 09:11:01 -0800
Subject: [PATCH] clk: introduce clk_is_match

Some drivers compare struct clk pointers as a means of knowing
if the two pointers reference the same clock hardware. This behavior is
dubious (drivers must not dereference struct clk), but did not cause any
regressions until the per-user struct clk patch was merged. Now the test
for matching clk's will always fail with per-user struct clk's.

clk_is_match is introduced to fix the regression and prevent drivers
from comparing the pointers manually.

Fixes: 035a61c314eb ("clk: Make clk API return per-user struct clk instances")
Cc: Russell King <redacted>
Cc: Stephen Boyd <redacted>
Cc: Shawn Guo <redacted>
Tested-by: Shawn Guo <redacted>
Cc: Tomeu Vizoso <redacted>
Signed-off-by: Michael Turquette <redacted>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help