Thread (14 messages) 14 messages, 5 authors, 2014-06-10

Re: [PATCH 1/2] serial: core: Don't drop DTR if system console

From: One Thousand Gnomes <hidden>
Date: 2014-06-09 13:08:42
Also in: lkml

On Wed,  4 Jun 2014 10:16:10 -0400
Peter Hurley [off-list ref] wrote:
If a tty is opened on a serial console, don't drop DTR on
last tty close, on tty hangup, or when resetting port hardware
via TIOCSSERIAL and TIOCSERCONFIG ioctls.

Signed-off-by: Peter Hurley <redacted>
NAK

This introduces a security flaw.

If you have a system with a remote console you dial into then with this
patch applied a modem drop eg from a bad line will no longer drop any
live session and ensure a login is required as it was before.

That's a pretty bad regression case.

If you are running a serial console and want to leave DTR high either
wire the cable that way or don't set HUPCL in the first place. The
technology for fixing this problem already exists!

Alan
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help