Thread (6 messages) 6 messages, 2 authors, 2014-02-06

Re: [PATCH] serial: sh_sci: remove HAVE_CLK build dependecy

From: Baruch Siach <baruch@tkos.co.il>
Date: 2014-02-06 07:38:01
Also in: linux-sh

Hi Simon,

On Thu, Feb 06, 2014 at 04:25:57PM +0900, Simon Horman wrote:
On Thu, Feb 06, 2014 at 09:18:21AM +0200, Baruch Siach wrote:
quoted
On Thu, Feb 06, 2014 at 03:40:56PM +0900, Simon Horman wrote:
quoted
On Wed, Feb 05, 2014 at 09:28:38PM +0200, Baruch Siach wrote:
quoted
Since 93abe8e4 (clk: add non CONFIG_HAVE_CLK routines) code using clk.h
like this driver needs not depend on HAVE_CLK.

Signed-off-by: Baruch Siach <baruch@tkos.co.il>
Acked-by: Simon Horman <redacted>
Thanks. This patch conflicts with another sh_sci patch you have just posted 
(http://article.gmane.org/gmane.linux.serial/13640). How would you like this 
to be handled?
Indeed it does, sorry for not noticing that.

Perhaps it would be best to drop the patch that I posted?
Why drop? There is no logical conflict between the patches, only textual. So 
we just need to serialize them to solve the conflict, and have them go via the 
same tree.

baruch
quoted
quoted
quoted
---
 drivers/tty/serial/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
index a3815eaed421..ce6fd1dd0864 100644
--- a/drivers/tty/serial/Kconfig
+++ b/drivers/tty/serial/Kconfig
@@ -708,7 +708,7 @@ config SERIAL_IP22_ZILOG_CONSOLE
 
 config SERIAL_SH_SCI
 	tristate "SuperH SCI(F) serial port support"
-	depends on HAVE_CLK && (SUPERH || ARM || COMPILE_TEST)
+	depends on SUPERH || ARM || COMPILE_TEST
 	select SERIAL_CORE
 
 config SERIAL_SH_SCI_NR_UARTS
-- 
1.8.5.3
-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help