Thread (5 messages) 5 messages, 3 authors, 2013-08-27

Re: [PATCH] serial: omap: Fix IRQ handling return value

From: Greg KH <gregkh@linuxfoundation.org>
Date: 2013-08-27 23:01:50
Also in: lkml

On Tue, Aug 20, 2013 at 08:44:50AM -0700, Kevin Hilman wrote:
+Felipe

On Wed, Jul 17, 2013 at 6:29 AM, Alexander Savchenko
[off-list ref] wrote:
quoted
From: Ruchika Kharwar <redacted>

Ensure the Interrupt handling routine return IRQ_HANDLED vs
IRQ_NONE.
Why?

By unconditionally returning IRQ_HANDLED, this patch will surely break
systems where the UART IRQ is shared with other platforms.

I just noticed this patch when bisecting a related problem.  Why
wasn't this Cc'd to linux-omap where OMAP users might have been more
likely to see it?

Greg, without a better justification in the changelog, I think this
patch should be dropped from tty-next.
Now reverted, sorry for the delay.

greg k-h
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help