On Fri, May 10, 2013 at 10:17:12AM +0200, Wolfram Sang wrote:
quoted hunk ↗ jump to hunk
devm_ioremap_resource does sanity checks on the given resource. No need to
duplicate this in the driver.
Signed-off-by: Wolfram Sang <redacted>
---
drivers/tty/serial/serial-tegra.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/tty/serial/serial-tegra.c b/drivers/tty/serial/serial-tegra.c
index 9799d04..9570b55 100644
--- a/drivers/tty/serial/serial-tegra.c
+++ b/drivers/tty/serial/serial-tegra.c
@@ -1295,13 +1295,9 @@ static int tegra_uart_probe(struct platform_device *pdev)
tup->cdata = cdata;
platform_set_drvdata(pdev, tup);
- resource = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- if (!resource) {
- dev_err(&pdev->dev, "No IO memory resource\n");
- return -ENODEV;
- }
u->mapbase = resource->start;
+ resource = platform_get_resource(pdev, IORESOURCE_MEM, 0);
You need to look at your scripts, as again, this is totally wrong.
greg k-h