[PATCH 7/7] tty/tty_ldisc.c: use test_and_clear_bit in tty_ldisc_close
From: George Spelvin <hidden>
Date: 2013-02-08 09:16:37
Subsystem:
the rest, tty layer and serial drivers · Maintainers:
Linus Torvalds, Greg Kroah-Hartman, Jiri Slaby
We have a function to test and clear a bit in one step, so use it. Signed-off-by: George Spelvin <redacted> --- drivers/tty/tty_ldisc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/tty/tty_ldisc.c b/drivers/tty/tty_ldisc.c
index c578229..4606ab9 100644
--- a/drivers/tty/tty_ldisc.c
+++ b/drivers/tty/tty_ldisc.c@@ -453,8 +453,7 @@ static int tty_ldisc_open(struct tty_struct *tty, struct tty_ldisc *ld) static void tty_ldisc_close(struct tty_struct *tty, struct tty_ldisc *ld) { - WARN_ON(!test_bit(TTY_LDISC_OPEN, &tty->flags)); - clear_bit(TTY_LDISC_OPEN, &tty->flags); + WARN_ON(!test_and_clear_bit(TTY_LDISC_OPEN, &tty->flags)); if (ld->ops->close) ld->ops->close(tty); }
--
1.8.1.2