RE: [PATCH] serial: samsung: remove redundant setting of line config during port reset
From: Kukjin Kim <hidden>
Date: 2012-12-31 22:04:00
Also in:
linux-samsung-soc
Thomas Abraham wrote:
The setting of uart line control configuration in s3c24xx_serial_resetport is can be removed since the 'set_termios' call will overwrite any ULCON register setting which s3c24xx_serial_resetport does. Cc: Kukjin Kim <redacted>
Acked-by: Kukjin Kim <redacted> Greg, if you're ok on this, please pick this up for v3.8 Happy New Year!!! - Kukjin
quoted hunk ↗ jump to hunk
Signed-off-by: Thomas Abraham <redacted> --- drivers/tty/serial/samsung.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)diff --git a/drivers/tty/serial/samsung.c b/drivers/tty/serial/samsung.c index 12e5249..e514b3a 100644 --- a/drivers/tty/serial/samsung.c +++ b/drivers/tty/serial/samsung.c@@ -1006,7 +1006,6 @@ static void s3c24xx_serial_resetport(structuart_port *port, ucon &= ucon_mask; wr_regl(port, S3C2410_UCON, ucon | cfg->ucon); - wr_regl(port, S3C2410_ULCON, cfg->ulcon); /* reset both fifos */ wr_regl(port, S3C2410_UFCON, cfg->ufcon | S3C2410_UFCON_RESETBOTH); -- 1.7.5.4