Re: [PATCH -next] serial: xilinx_uartps: fix return value check in xuartps_probe()
From: Grant Likely <hidden>
Date: 2012-12-05 23:57:49
Also in:
linux-devicetree
On Sun, 2 Dec 2012 05:12:43 -0500, Wei Yongjun [off-list ref] wrote:
From: Wei Yongjun <redacted> In case of error, function of_clk_get() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be replaced with IS_ERR(). Signed-off-by: Wei Yongjun <redacted>
Acked-by: Grant Likely <redacted>
quoted hunk ↗ jump to hunk
--- drivers/tty/serial/xilinx_uartps.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c index 2be22a2..1eb4657 100644 --- a/drivers/tty/serial/xilinx_uartps.c +++ b/drivers/tty/serial/xilinx_uartps.c@@ -948,9 +948,9 @@ static int xuartps_probe(struct platform_device *pdev) struct clk *clk; clk = of_clk_get(pdev->dev.of_node, 0); - if (!clk) { + if (IS_ERR(clk)) { dev_err(&pdev->dev, "no clock specified\n"); - return -ENODEV; + return PTR_ERR(clk); } rc = clk_prepare_enable(clk);
-- Grant Likely, B.Sc, P.Eng. Secret Lab Technologies, Ltd.