Thread (17 messages) 17 messages, 7 authors, 2012-12-20

Re: [PATCH] serial: tegra: add serial driver

From: Stephen Warren <hidden>
Date: 2012-12-17 21:31:39
Also in: linux-devicetree, linux-tegra, lkml

On 12/17/2012 10:10 AM, Grant Likely wrote:
On Mon, 17 Dec 2012 17:40:49 +0530, Laxman Dewangan [off-list ref] wrote:
quoted
Nvidia's Tegra has multiple uart controller which supports:
- APB dma based controller fifo read/write.
- End Of Data interrupt in incoming data to know whether end
  of frame achieve or not.
- Hw controlled RTS and CTS flow control to reduce SW overhead.
quoted
+static int __devinit tegra_uart_probe(struct platform_device *pdev)
+{
+	struct tegra_uart_port *tup;
+	struct uart_port *u;
+	struct tegra_uart_platform_data *pdata = pdev->dev.platform_data;
Since this is a new driver, and all new board support will use device
tree, when would this platform_data pointer get set? Can you drop the
platform_data support code entirely?
Aren't we still supposed to support platform data so that it can
override what's in DT in order to fix up bad DTs? Or, has that
requirement been dropped. If it has, we can drop a bunch of code from a
variety of Tegra-specific drivers, I expect.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help