Re: [PATCH 5/5] serial: 8250_dw: Set FIFO size dynamically

[PATCH 0/5] serial: 8250: 8250_dw changes and dynamic capabilities · Heikki Krogerus <heikki.krogerus@linux.intel.com> · 2012-11-28
[PATCH 1/5] serial: 8250: Allow drivers to deliver capabilities · Heikki Krogerus <heikki.krogerus@linux.intel.com> · 2012-11-28
[PATCH 2/5] serial: 8250_dw: Don't use UPF_FIXED_TYPE · Heikki Krogerus <heikki.krogerus@linux.intel.com> · 2012-11-28
[PATCH 4/5] serial: 8250_dw: Move device tree code to separate function · Heikki Krogerus <heikki.krogerus@linux.intel.com> · 2012-11-28
[PATCH 5/5] serial: 8250_dw: Set FIFO size dynamically · Heikki Krogerus <heikki.krogerus@linux.intel.com> · 2012-11-28
Re: [PATCH 5/5] serial: 8250_dw: Set FIFO size dynamically · Alan Cox <hidden> · 2012-11-28
Re: [PATCH 5/5] serial: 8250_dw: Set FIFO size dynamically · Heikki Krogerus <heikki.krogerus@linux.intel.com> · 2012-11-28
[PATCH 5/5] serial: 8250_dw: Set FIFO size dynamically · Heikki Krogerus <heikki.krogerus@linux.intel.com> · 2012-11-28
[PATCH 3/5] serial: 8250_dw: Map IO memory · Heikki Krogerus <heikki.krogerus@linux.intel.com> · 2012-11-28
Re: [PATCH 0/5] serial: 8250: 8250_dw changes and dynamic capabilities · Heikki Krogerus <heikki.krogerus@linux.intel.com> · 2012-11-30

From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Date: 2012-11-28 13:37:10
Also in: lkml

On Wed, Nov 28, 2012 at 01:18:26PM +0000, Alan Cox wrote:

quoted

+	if (!reg || (reg & 0xff) != '*')
+		return;
+

That looks bogus. If reg == 0 then reg & 0xFF != '*'

So why the double test ?

No reason. It is something I forgot to cleanup. I'll resend this.

Thanks!

-- 
heikki