Re: [PATCH] serial: omap: Remove unnecessary checks from suspend/resume
From: Poddar, Sourav <hidden>
Date: 2012-09-21 05:10:44
Also in:
linux-arm-kernel, linux-omap
Possibly related (same subject, not in this thread)
- 2012-09-18 · [PATCH] serial: omap: Remove unnecessary checks from suspend/resume · Poddar, Sourav <hidden>
- 2012-09-18 · [PATCH] serial: omap: Remove unnecessary checks from suspend/resume · Sourav Poddar <hidden>
- 2012-09-18 · [PATCH] serial: omap: Remove unnecessary checks from suspend/resume · Felipe Balbi <hidden>
Hi Kevin, On Thu, Sep 20, 2012 at 3:13 AM, Kevin Hilman [off-list ref] wrote:
"Poddar, Sourav" [off-list ref] writes:quoted
Hi Felipe, On Tue, Sep 18, 2012 at 5:04 PM, Felipe Balbi [off-list ref] wrote:quoted
On Tue, Sep 18, 2012 at 05:05:54PM +0530, Sourav Poddar wrote:quoted
Drop the check for "up" being valid on suspend/resume callbacks. It should be valid always. Get rid of the "pdata" check also as serial_omap_get_context_loss_count() checks for it. Tested on omap4 panda and 3630 based Beagle board.you need a blank line here. Other than that: Reviewed-by: Felipe Balbi <redacted> ps: what kind of tests did you run, btw ?Boot tested on Panda. Boot and PM tested(hitiing Off) on Beagle.What does "PM tested" mean. hitting off in idle? hitting off in suspend? both?
Hitting off in both idle and suspend.
Please clarify. Thanks, Kevin
~Sourav