Thread (18 messages) 18 messages, 5 authors, 2012-09-26
STALE5005d

Re: [PATCH 3/3] serial: pl011: allow very high baudrates

From: Russell King - ARM Linux <hidden>
Date: 2012-09-20 19:00:34
Also in: linux-arm-kernel

On Thu, Sep 20, 2012 at 11:46:08AM +0200, Linus Walleij wrote:
From: Linus Walleij <redacted>

The ST Microelectronics variant of the PL011 is capable of supporting
very high non-standard baud rates, even above 4 Mbps. However the
uart_get_baud_rate() will not allow us to set these, so override that
calculation on very high speeds.
You don't explain why it doesn't.  It should in theory allow you to,
because there's no limits within that function other than those which
you pass in as the minimum and maximum.

If your userspace hasn't been updated to use the integer baud rate
setting mechanisms, then that could be where the problem lies.
Alternatively, if some Bxxxx setting is not being respected by
tty_termios_baud_rate(), that also would need fixing.

But the fix you propose in this patch just looks wrong.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help