On Mon, Sep 3, 2012 at 2:45 PM, Jiri Slaby [off-list ref] wrote:

On 09/03/2012 11:24 PM, Joe Millenbach wrote:

quoted

I do not have a Power PC system to test on

Neither do I. But that is no excuse to break it. There are
cross-compilers for instance.

True.  I was not saying I should leave it, only why I did not catch it
sooner and was asking for a better way.

quoted

so during my testing I did
not notice that option would need TTY also.  Thanks for pointing that
out.  Before I spin a new patch is there anything else I should add?
I do not know of a way for me to easily test all the different CPU
specific configurations on my x86 based machines.

Basically everything that does alloc_tty_driver...

You should minimize the risk of breaking !TTY builds (randconfig for
example) on other arches as much as possible. I'm not trying to force
you to do allmodconfig minus TTY on all arches, but at least do 'git
grep' thoroughly.

thanks,
--
js
suse labs

Perfect, I'll go through this list and make sure I've handled all of them.

Thanks for your time,
Joe