Re: restart callback not supposed to sleep?
From: Lothar Waßmann <hidden>
Date: 2012-08-20 08:57:34
Also in:
linux-arm-kernel
Hi, Uwe Kleine-König writes:
Hello,
while triggering a reboot via sysrq on an ARM machine I saw a "BUG:
sleeping function called from invalid context" message (details below).
The reason is that the sysrq handler is calling the restart hook in irq
context. So what should be done about that? The obvious possiblities
are:
a) ignore the problem as it won't result in problems (and maybe somehow
silence the warnign); or
b) make the restart hook atomic; or
c) assert sysrq not calling the hook in atomic mode
What do you think?This has been discussed earlier (with your participation) with 'a)' being the conclusion. http://lists.infradead.org/pipermail/linux-arm-kernel/2010-December/033877.html Lothar Waßmann -- ___________________________________________________________ Ka-Ro electronics GmbH | Pascalstraße 22 | D - 52076 Aachen Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10 Geschäftsführer: Matthias Kaussen Handelsregistereintrag: Amtsgericht Aachen, HRB 4996 www.karo-electronics.de | info@karo-electronics.de ___________________________________________________________ -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html