Re: [PATCHv4 1/1] [RFC] uartclk from serial_core exposed to sysfs
From: Tomas Hlavacek <hidden>
Date: 2012-08-21 13:24:55
Also in:
lkml
From: Tomas Hlavacek <hidden>
Date: 2012-08-21 13:24:55
Also in:
lkml
Hello! On Sun, Aug 19, 2012 at 8:34 PM, Tomas Hlavacek [off-list ref] wrote:
Added file /sys/devices/.../tty/ttySX/uartclk to allow reading uartclk value in struct uart_port in serial_core via sysfs. It simplifies initialization verification of no-name cards that have non-standard oscillator speed while having no distinguishing PCI IDs to allow autodetection. tty_register_device() has been generalized and refactored in order to add support for setting drvdata and attribute_group to the device.
I have updated the patch to a new v4 in order to remove the race in sysfs file creation and add sysfs file description to a Documentation directory. But still the patch creates the sysfs file separately for each serial TTY device by assigning attribute_groups to the struct device and not for the whole driver at once as Greg advised because I was unable to figure out how to do that (even though I tried pretty hard). Does it make sense like this? Or do you have any hint for a better way to do it, please? Thanks, Tomas