Re: [PATCH] serial: sc26xx: Fix compile breakage
From: Alexander Shiyan <hidden>
Date: 2012-08-01 17:44:24
On Wed, 1 Aug 2012 08:04:40 -0700 Greg Kroah-Hartman [off-list ref] wrote:
On Wed, Aug 01, 2012 at 06:55:30PM +0400, Alexander Shiyan wrote:quoted
Wed, 1 Aug 2012 05:56:37 -0700 от Greg Kroah-Hartman [off-list ref]:quoted
On Wed, Aug 01, 2012 at 12:00:20PM +0400, Alexander Shiyan wrote:quoted
This patch fixes the following compile breakage: CC drivers/tty/serial/sc26xx.o drivers/tty/serial/sc26xx.c: In function 'read_sc_port': drivers/tty/serial/sc26xx.c:100: error: implicit declaration of function 'readb' drivers/tty/serial/sc26xx.c: In function 'write_sc_port': drivers/tty/serial/sc26xx.c:105: error: implicit declaration of function 'writeb' drivers/tty/serial/sc26xx.c: In function 'sc26xx_probe': drivers/tty/serial/sc26xx.c:652: error: implicit declaration of function 'ioremap_nocache' drivers/tty/serial/sc26xx.c:652: warning: assignment makes pointer from integer without a cast make[3]: *** [drivers/tty/serial/sc26xx.o] Error 1 make[2]: *** [drivers/tty/serial] Error 2 make[1]: *** [drivers/tty] Error 2 make: *** [drivers] Error 2Breakage in what tree? What caused this to break?Breakage due to missing header linux/io.h.Again, where did this break (3.4, 3.5, 3.6-rc1, 2.6.32, etc.) and what caused it to break (what patch?)
I'm using kernel 3.4.5. Perhaps, the problem not in header that missing, but is that I build a driver for ARM platform, i.e. with a patched Makefile. In any case, you can just drop this patch. I use these ICs with ARM architecture, and so I write an improved version of the driver that will support all ICs from this series and do not depend on the architecture. -- Alexander Shiyan [off-list ref] -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html