On Wed, May 02, 2012 at 10:41:12AM -0400, Paul Gortmaker wrote:

On 12-05-02 08:47 AM, Magnus Damm wrote:

quoted

From: Magnus Damm <redacted>

Add a platform driver for Emma Mobile 8250 hardware.

[...]

quoted

+
+config SERIAL_8250_EM
+	tristate "Support for Emma Mobile intergrated serial port"
+	depends on SERIAL_8250

Should we depend on arch=ARM or something similar?  Even if the
driver is written to be arch independent, if the Emma itself is
physically tied to ARM platforms, we probably don't need to be
building it for sparc allyesconfig etc.

Yeah, it doesn't build on x86-64, I get the following build problems:
	ERROR: "clk_get_rate" [drivers/tty/serial/8250/8250_em.ko] undefined!
	ERROR: "clk_enable" [drivers/tty/serial/8250/8250_em.ko] undefined!
	ERROR: "clk_get" [drivers/tty/serial/8250/8250_em.ko] undefined!
	ERROR: "clk_put" [drivers/tty/serial/8250/8250_em.ko] undefined!
	ERROR: "clk_disable" [drivers/tty/serial/8250/8250_em.ko] undefined!

So it should depend on some arch that has clk at the least.

Magnus, care to redo just this one patch that fixes this up?  I've
applied the first 5 already.

thanks,

greg k-h