Re: [PATCH 15/68] TTY: ipwireless, fix tty->index handling
From: Jiri Kosina <hidden>
Date: 2012-03-05 14:03:33
Also in:
lkml
From: Jiri Kosina <hidden>
Date: 2012-03-05 14:03:33
Also in:
lkml
On Mon, 5 Mar 2012, Jiri Slaby wrote:
* do not test if tty->index is in bounds. It is always. * tty->index is not a minor! Fix that.quoted
From now on, let's assume that the parameter of the function is ttyindex with base being zero. This makes also the code more readable. Factually, there is no real change as tty_driver->minor_start is zero, so the tests are equivalent. But it did not make sense. And if this had changed eventually, it would have caused troubles. Signed-off-by: Jiri Slaby <redacted> Cc: Jiri Kosina <redacted> Cc: David Sterba <redacted>
Acked-by: Jiri Kosina <redacted> Thanks Jiri. -- Jiri Kosina SUSE Labs